-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to check for required reviews #370
Conversation
f37ed0a
to
f86a53a
Compare
903f9c2
to
1e3251b
Compare
3af646f
to
438f600
Compare
438f600
to
536d9dd
Compare
Add review checking script Simplify with workflow event Remove condition for approval Also run when unlabeled Colourise output
The run on pull_request is treated as a seperate check and isn't updated when a review is actually made.
57f9e49
to
506193d
Compare
The workflow might need to run on pull_request, as currently there are a lot of circumstances where it doesn't run. At least it terminates early, so it shouldn't slow things down over running only on a review being submitted. The issue with running on pull_request is that it won't rerun after the reviews, so it would still stay failed after the needed reviews had been gathered... |
I think for most changes 2 reviews should be sufficient as 3 reviews but slow process down too much and stop users from adotping the tool if overhead is too much. |
I'm tempted to drop this PR as it has a few edge cases it can break on, which fixing would make it significantly more complicated. Instead we should just go for an honour system, and note at the top of the PR if it requires multiple reviews. |
Fixes #366.